fix: CMD + arrows should not navigate RAC Tabs as it's a browser shortcut#9650
Open
Zdog1206 wants to merge 2 commits intoadobe:mainfrom
Open
fix: CMD + arrows should not navigate RAC Tabs as it's a browser shortcut#9650Zdog1206 wants to merge 2 commits intoadobe:mainfrom
Zdog1206 wants to merge 2 commits intoadobe:mainfrom
Conversation
Fix issue adobe#9648 such that pressing CMD + left/right arrow actually triggers the browser's forward and back actions instead of moving between the tabs on the screen.
Another user requested the code be written slightly differently to avoid issues in other parts of the program.
snowystinger
changed the title
| } | ||
| }; | ||
|
|
||
| if (manager.selectionMode === 'single' && (e.metaKey || e.altKey)) { |
Member
There was a problem hiding this comment.
This is close, but it's going to affect too many things. I think it should be restricted to Left/Right arrows OR handling should be moved to the Tab's keyboard delegate.
Otherwise it may interfere with some of our selectionMode+selectionBehaviour https://react-aria.adobe.com/ListBox#selection
It looks like Up/Down + meta scrolls the entire page or moves the text cursor to the start or end of an input. I think in Tabs it shouldn't do anything. Much like the Toolbar in this github comment box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes <#9648>
📝 Test Instructions: